Zoo features, agent team #1305
Merged
Zoo features, agent team #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moratom
reviewed
May 7, 2025
Comment on lines
+89
to
+96
| * @param progressFormat: Format to use for progress output (possible values: pretty, json, none), default is "none" | ||
| * @return std::string: Path to the model in cache | ||
| */ | ||
| std::string getModelFromZoo(const NNModelDescription& modelDescription, | ||
| bool useCached = true, | ||
| const std::string& cacheDirectory = "", | ||
| const std::string& apiKey = ""); | ||
| const std::string& apiKey = "", | ||
| const std::string& progressFormat = "none"); |
There was a problem hiding this comment.
Any specific reason to not go with an enum here instead of a string?
There was a problem hiding this comment.
True, will make it an enum. This was the quickest but at the same time dirtiest implementation :D
moratom
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add
zoo_helper-related features requested by the agent team.This PR should only be merged after #1304